libstore-c: Add new derivation and store path functions #14555
+1,075
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
more-store-ffi
branch
from
64ac27b to
601f966
Compare
github-actions
bot
added
new-cli
Ericson2314
force-pushed
the
more-store-ffi
branch
from
601f966 to
58acb5e
Compare
roberth
reviewed
Nov 13, 2025
src/libstore-c/nix_api_store.h
Outdated
| nix_c_context * context, | ||
| Store * store, | ||
| const StorePath * path, | ||
| void (*callback)(void * userdata, const nix_derivation * drv), |
Member
There was a problem hiding this comment.
Let's propagate the error. I'd say it's more useful for early abort scenarios (multiple calls), but still useful here to use the same error handling mechanism.
Suggested change
| void (*callback)(void * userdata, const nix_derivation * drv), | |
| nix_err (*callback)(nix_c_context * return_ctx, void * userdata, const nix_derivation * drv), |
Member
Author
There was a problem hiding this comment.
Since derivations internally heap allocate, I think I will just make this return a pointer to a derivation on the heap too.
Ericson2314
force-pushed
the
more-store-ffi
branch
3 times, most recently
from
91bb0a1 to
20347d7
Compare
Member
Author
|
OK I moved some of the new stuff in to https://github.com/NixOS/nix/tree/more-store-ffi-2 so this is smaller in scope. |
Ericson2314
force-pushed
the
more-store-ffi
branch
from
20347d7 to
a568edd
Compare
These do a read/write test in the middles of some computation. They are an imperative way to test intermediate values rather than functionally testing end outputs.
`nix derivation add`, and its C API counterpart, now works a bit closer to `builtins.derivation` in that they don't require the user to fill-in input addressed paths correctly ahead of time. The logic for this is carefully deduplicated, between all 3 entry points, and also between the existing `checkInvariants` function. There are some more functional tests, and there are also many more unit tests. Co-authored-by: Sergei Zimmerman <[email protected]> Co-authored-by: edef <[email protected]>
Ericson2314
changed the title
Add several new functions to the C API: StorePath operations: - nix_store_path_hash: Extract the hash part from a store path - nix_store_create_from_parts: Construct a store path from hash and name Derivation operations: - nix_derivation_clone: Clone a derivation - nix_derivation_to_json: Serialize a derivation to JSON Store operations: - nix_store_drv_from_store_path: Load a derivation from a store path Test the new functions, and improve documentation of some existing functions to better distinguish them, also. Co-authored-by: Tristan Ross <[email protected]> Co-authored-by: Robert Hensing <[email protected]>
Ericson2314
force-pushed
the
more-store-ffi
branch
from
a568edd to
5831567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying out new and improved FFI with new and improved bindings + Harmonia.
Context
Rebase of #14031
Depends on #14560
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.